internal/helm/refs_truncated_test.go

Rama main · réplica de lectura del repositorio original.

package helm

import (
	"errors"
	"fmt"
	"testing"

	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/apimachinery/pkg/runtime"
	metadatafake "k8s.io/client-go/metadata/fake"
	k8stesting "k8s.io/client-go/testing"
)

func pageOf(items int) func(k8stesting.Action) (bool, runtime.Object, error) {
	return pageWith(items, "there-is-more")
}

func pageWith(items int, more string) func(k8stesting.Action) (bool, runtime.Object, error) {
	return func(k8stesting.Action) (bool, runtime.Object, error) {
		list := &metav1.List{Continue: more}
		for i := range items {
			list.Items = append(list.Items, runtime.RawExtension{Object: &metav1.PartialObjectMetadata{
				Name:      fmt.Sprintf("sh.helm.release.v1.web.v%d", i),
				Namespace: "prod",
				Labels:    map[string]string{"owner": "helm"},
			}})
		}
		return true, list, nil
	}
}

func TestANamespaceFallbackThatExactlyFitsIsComplete(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(), namespaceMeta("prod"))
	client.PrependReactor("list", "secrets", func(action k8stesting.Action) (bool, runtime.Object, error) {
		if action.GetNamespace() == "" {
			return true, nil, forbiddenSecrets("no cluster-wide secrets")
		}
		return pageWith(maxObjects, "")(action)
	})

	page, err := refsWithFallback(t.Context(), client, DriverSecret, secretsGVR, "secrets")
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want all %d", len(page.items), maxObjects)
	}
	if page.truncated {
		t.Fatal("a complete final namespace was reported as truncated")
	}
}

func TestANamespaceFallbackThatFillsBeforeTheLastNamespaceIsTruncated(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(), namespaceMeta("one"), namespaceMeta("two"))
	client.PrependReactor("list", "secrets", func(action k8stesting.Action) (bool, runtime.Object, error) {
		if action.GetNamespace() == "" {
			return true, nil, forbiddenSecrets("no cluster-wide secrets")
		}
		return pageWith(maxObjects, "")(action)
	})

	page, err := refsWithFallback(t.Context(), client, DriverSecret, secretsGVR, "secrets")
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("an unvisited namespace after the cap was reported as a complete read")
	}
}

func TestANamespaceFallbackNeverReturnsPastItsCap(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(), namespaceMeta("prod"))
	client.PrependReactor("list", "secrets", func(action k8stesting.Action) (bool, runtime.Object, error) {
		if action.GetNamespace() == "" {
			return true, nil, forbiddenSecrets("no cluster-wide secrets")
		}
		return pageWith(maxObjects+17, "")(action)
	})

	page, err := refsWithFallback(t.Context(), client, DriverSecret, secretsGVR, "secrets")
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("objects discarded at the cap were reported as a complete read")
	}
}

func TestANamespaceFallbackCapsTheCombinedNamespaces(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(), namespaceMeta("one"), namespaceMeta("two"))
	client.PrependReactor("list", "secrets", func(action k8stesting.Action) (bool, runtime.Object, error) {
		if action.GetNamespace() == "" {
			return true, nil, forbiddenSecrets("no cluster-wide secrets")
		}
		if action.GetNamespace() == "one" {
			return pageWith(3, "")(action)
		}
		return pageWith(maxObjects, "")(action)
	})

	page, err := refsWithFallback(t.Context(), client, DriverSecret, secretsGVR, "secrets")
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("objects discarded across namespaces were reported as a complete read")
	}
}

func TestReadingStopsAtTheObjectCapAndSaysSo(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme())
	client.PrependReactor("list", "secrets", pageOf(maxObjects))

	page, err := listRefs(t.Context(), client, DriverSecret, secretsGVR, "prod")
	if err != nil {
		t.Fatalf("list: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want it to stop at the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("a list that stopped early did not say it was truncated")
	}
}

func TestAListResponseNeverPushesTheResultPastItsCap(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme())
	client.PrependReactor("list", "secrets", pageWith(maxObjects+17, ""))

	page, err := listRefs(t.Context(), client, DriverSecret, secretsGVR, "prod")
	if err != nil {
		t.Fatalf("list: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("objects discarded from an oversized page were reported as a complete read")
	}
}

func TestAListThatFitsIsNotCalledTruncated(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(),
		&metav1.PartialObjectMetadata{
			APIVersion: "v1", Kind: "Secret",
			Name:      "sh.helm.release.v1.web.v1",
			Namespace: "prod",
			Labels:    map[string]string{"owner": "helm"},
		})

	page, err := listRefs(t.Context(), client, DriverSecret, secretsGVR, "prod")
	if err != nil {
		t.Fatalf("list: %v", err)
	}
	if page.truncated {
		t.Fatal("a list that read everything reported itself truncated")
	}
}

func TestARefWalkRejectsARepeatedContinueToken(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme())
	client.PrependReactor("list", "secrets", func(k8stesting.Action) (bool, runtime.Object, error) {
		return true, &metav1.List{Continue: "same"}, nil
	})

	_, err := listRefs(t.Context(), client, DriverSecret, secretsGVR, "prod")

	if !errors.Is(err, errRepeatedContinue) {
		t.Fatalf("ref list error = %v, want the repeated token", err)
	}
}

func TestTruncationTravelsUpToTheWholeRead(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(),
		&metav1.PartialObjectMetadata{
			APIVersion: "v1", Kind: "Namespace",
			Name: "prod",
		})
	client.PrependReactor("list", "secrets", pageOf(maxObjects))

	page, err := allRefs(t.Context(), client)
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if !page.truncated {
		t.Fatal("a read that stopped at the cap was reported as complete")
	}
}

func TestANamespaceFallbackThatHitsTheCapStillSaysItWasTruncated(t *testing.T) {
	client := metadatafake.NewSimpleMetadataClient(metaScheme(), namespaceMeta("prod"))
	client.PrependReactor("list", "secrets", func(action k8stesting.Action) (bool, runtime.Object, error) {
		if action.GetNamespace() == "" {
			return true, nil, forbiddenSecrets("no cluster-wide secrets")
		}
		return pageOf(maxObjects)(action)
	})

	page, err := allRefs(t.Context(), client)
	if err != nil {
		t.Fatalf("refs: %v", err)
	}
	if len(page.items) != maxObjects {
		t.Fatalf("read %d objects, want the cap of %d", len(page.items), maxObjects)
	}
	if !page.truncated {
		t.Fatal("a namespace fallback that stopped at the cap was reported as complete")
	}
}