internal/checks/corpuscustom_test.go

Rama main · réplica de lectura del repositorio original.

package checks

import (
	"errors"
	"fmt"
	"testing"

	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"

	"github.com/sophotechlabs/spinoza/internal/api"
)

func clusterIssuer(name, secret string) *unstructured.Unstructured {
	return &unstructured.Unstructured{Object: map[string]any{
		"apiVersion": "cert-manager.io/v1",
		"kind":       "ClusterIssuer",
		"metadata":   map[string]any{"name": name},
		"spec": map[string]any{
			"acme": map[string]any{
				"privateKeySecretRef": map[string]any{"name": secret},
			},
		},
	}}
}

func TestASecretACustomResourceNamesIsNotOrphaned(t *testing.T) {
	report := report(t,
		simple("Secret", "letsencrypt-account", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"))

	if findingCount(t, report, "orphaned-secret") != 0 {
		t.Fatal("a secret a ClusterIssuer names was reported as referenced by nothing")
	}
}

func TestASecretNothingNamesIsStillOrphaned(t *testing.T) {
	report := report(t,
		simple("Secret", "forgotten", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"))

	if findingCount(t, report, "orphaned-secret") != 1 {
		t.Fatal("a secret nothing names was not reported once the custom resources were read")
	}
}

func TestTheCustomResourcesAreReadWithoutBeingAskedFor(t *testing.T) {
	found := customKinds(descriptors())

	if len(found) != 1 || found[0].Resource != "clusterissuers" {
		t.Fatalf("the custom kinds were %v", found)
	}
}

func TestCustomResourceKindsAreReturnedInStableOrder(t *testing.T) {
	descs := descriptors()
	descs["example.io/v1/widgets"] = api.ResourceDescriptor{
		Group: "example.io", Version: "v1", Resource: "widgets", Kind: "Widget", Category: customResources,
	}

	found := customKinds(descs)

	if len(found) != 2 {
		t.Fatalf("custom kinds = %+v, want two", found)
	}
	if descKey(found[0]) >= descKey(found[1]) {
		t.Fatalf("custom kinds = %+v, want stable key order", found)
	}
}

func TestCorpusLookupsKeepNamesAndNamespacesSeparate(t *testing.T) {
	desc := api.ResourceDescriptor{Version: "v1", Resource: "configmaps", Kind: "ConfigMap"}
	items := []held{
		{desc: desc, obj: simple("ConfigMap", "alpha", "team-a", nil)},
		{desc: desc, obj: simple("ConfigMap", "beta", "team-b", nil)},
	}
	corpus := newCorpus(items, nil, nil, []target{{resource: "configmaps"}}, nil, nil)

	if !corpus.named("", "configmaps", "team-b", "beta") {
		t.Fatal("the exact ConfigMap was not found")
	}
	if corpus.named("", "configmaps", "team-b", "alpha") {
		t.Fatal("a ConfigMap in another namespace matched")
	}
	if got := corpus.inNamespace("", "configmaps", "team-a"); len(got) != 1 || got[0].GetName() != "alpha" {
		t.Fatalf("team-a ConfigMaps = %+v, want alpha", got)
	}
}

func TestExtraWarmKindsAreUniqueSortedAndBounded(t *testing.T) {
	already := api.ResourceDescriptor{Group: "apps", Version: "v1", Resource: "deployments"}
	lister := newLister()
	lister.cached = []api.ResourceDescriptor{already}
	for at := 30; at >= 0; at-- {
		lister.cached = append(lister.cached, api.ResourceDescriptor{
			Group: "example.io", Version: "v1", Resource: fmt.Sprintf("resources-%02d", at),
		})
	}
	lister.cached = append(lister.cached, lister.cached[1])

	got := alsoWarm(lister, []api.ResourceDescriptor{already})

	if len(got) != extraWarmKinds {
		t.Fatalf("warm kinds = %d, want cap %d", len(got), extraWarmKinds)
	}
	seen := map[string]bool{descKey(already): true}
	for at, desc := range got {
		key := descKey(desc)
		if seen[key] {
			t.Fatalf("warm kinds repeat %q", key)
		}
		seen[key] = true
		if at > 0 && descKey(got[at-1]) >= key {
			t.Fatalf("warm kinds are not sorted at %q", key)
		}
	}
}

func TestAnAuditOfTheWorkloadsAloneLeavesTheCustomResourcesUnread(t *testing.T) {
	report := Run(t.Context(), newLister(
		simple("Secret", "forgotten", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	), descriptors(), api.Metrics{}, Filter{}, 0)

	if groupNamed(t, report, "orphaned-secret").Skipped == "" {
		t.Fatal("an orphan check answered from an audit that never read the custom resources")
	}
}

func TestACustomResourceIsReadWithoutACacheBehindIt(t *testing.T) {
	lister := newLister(
		simple("Secret", "letsencrypt-account", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	)

	Run(t.Context(), lister, descriptors(), api.Metrics{}, wholeCluster(), 0)

	if lister.scanCount() == 0 {
		t.Fatal("the custom resources were read through a cache the window keeps")
	}
}

func TestWhatACustomResourceNamesIsKeptWithoutKeepingTheResource(t *testing.T) {
	lister := newLister(
		simple("Secret", "letsencrypt-account", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	)

	report := Run(t.Context(), lister, descriptors(), api.Metrics{}, wholeCluster(), 0)

	if findingCount(t, report, "orphaned-secret") != 0 {
		t.Fatal("the name a custom resource mentions was lost with the resource")
	}
	for _, object := range report.Objects {
		if object.Kind == "ClusterIssuer" {
			t.Fatal("a custom resource was kept in the report it was only read to inform")
		}
	}
}

func TestNothingIsReadForACheckNobodyAskedFor(t *testing.T) {
	lister := newLister(
		simple("Secret", "letsencrypt-account", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	)
	keep := wholeCluster()
	keep.Disabled = []string{"orphaned-secret", "orphaned-config-map"}

	Run(t.Context(), lister, descriptors(), api.Metrics{}, keep, 0)

	if lister.scanCount() != 0 {
		t.Fatal("the custom resources were read although nothing in the audit needed them")
	}
}

func TestTheSeverityFloorAloneCanStopTheCustomResourcesBeingRead(t *testing.T) {
	lister := newLister(
		simple("Secret", "letsencrypt-account", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	)
	keep := wholeCluster()
	keep.MinSeverity = severityHigh

	Run(t.Context(), lister, descriptors(), api.Metrics{}, keep, 0)

	if lister.scanCount() != 0 {
		t.Fatal("a high-only audit still read every custom resource for a low check it dropped")
	}
}

func TestACustomKindThatCannotBeListedStopsTheOrphanChecks(t *testing.T) {
	lister := newLister(
		simple("Secret", "forgotten", testNamespace, nil),
		clusterIssuer("letsencrypt", "letsencrypt-account"),
	)
	lister.errs["clusterissuers"] = errors.New("clusterissuers is forbidden")

	report := Run(t.Context(), lister, descriptors(), api.Metrics{}, wholeCluster(), 0)

	if findingCount(t, report, "orphaned-secret") != 0 {
		t.Fatal("a refused custom resource listing became a secret nothing references")
	}
}