agents/postRun.test.ts

Rama main · réplica de lectura del repositorio original.

import { describe, expect, it } from "vitest";
import type { PayloadEvent } from "../external.ts";
import type { ToolState } from "../toolState.ts";
import { getUnsubmittedReview } from "./postRun.ts";

const prEvent: PayloadEvent = {
  trigger: "pull_request_opened",
  issue_number: 1,
  is_pr: true,
  title: "t",
  body: null,
  branch: "b",
};

function makeCtx(overrides: Partial<ToolState> = {}) {
  const toolState: ToolState = {
    repos: new Map([["o/r", { owner: "o", name: "r", dir: "/tmp/r", access: "primary" }]]),
    primaryRepoKey: "o/r",
    startedAt: 0,
    progressComment: { status: "unseeded" },
    hadProgressComment: true,
    prepushFailureCount: 0,
    noopReviewSubmissions: 0,
    backgroundProcesses: new Map(),
    usageEntries: [],
    ...overrides,
  };
  return { toolState, payload: { event: prEvent } };
}

describe("getUnsubmittedReview", () => {
  it("returns null when mode is not a review mode", () => {
    expect(getUnsubmittedReview(makeCtx({ selectedMode: "Build" }))).toBeNull();
    expect(getUnsubmittedReview(makeCtx())).toBeNull();
  });

  it("returns null when a review was already submitted", () => {
    expect(
      getUnsubmittedReview(
        makeCtx({
          selectedMode: "Review",
          review: { id: 1, nodeId: "n", reviewedSha: undefined },
        })
      )
    ).toBeNull();
  });

  it("fires for Review even when report_progress wrote a final summary", () => {
    // Review's only valid exit is `create_pull_request_review`. a summary
    // comment is not a substitute, and accepting it here previously let
    // subagent-flipped `finalSummaryWritten` silence the gate.
    expect(
      getUnsubmittedReview(makeCtx({ selectedMode: "Review", finalSummaryWritten: true }))
    ).toBe("Review");
  });

  it("returns null for IncrementalReview when report_progress wrote a final summary", () => {
    // IncrementalReview treats `report_progress` as a legitimate
    // "no review warranted" exit, matching the post-failure error message.
    expect(
      getUnsubmittedReview(
        makeCtx({ selectedMode: "IncrementalReview", finalSummaryWritten: true })
      )
    ).toBeNull();
  });

  it("returns null when there is no progress comment to anchor the failure to", () => {
    expect(
      getUnsubmittedReview(makeCtx({ selectedMode: "Review", hadProgressComment: false }))
    ).toBeNull();
  });

  it("returns the selected mode when the gate should fire", () => {
    expect(getUnsubmittedReview(makeCtx({ selectedMode: "Review" }))).toBe("Review");
    expect(getUnsubmittedReview(makeCtx({ selectedMode: "IncrementalReview" }))).toBe(
      "IncrementalReview"
    );
  });
});