tests/test_go_interface_methods.py
Rama v8 · réplica de lectura del repositorio original.
"""Regression coverage for method requirements declared in a Go interface.
The interface body carries the type's contract. Before the fix the extractor
only handled interface embedding and generic type-set constraints, so an
interface like ``type Reader interface { Read(p []byte) (int, error) }`` became
an empty node with no members - the method requirements were dropped entirely.
"""
from pathlib import Path
import pytest
from graphify.extract import extract
def _extract(root: Path) -> dict:
return extract(
sorted(root.rglob("*.go")),
cache_root=root,
root=root,
parallel=False,
)
def _methods_of(result: dict, type_label: str) -> set[str]:
"""Labels of nodes reached by a ``method`` edge from the named type."""
by_id = {node["id"]: node for node in result["nodes"]}
type_ids = {nid for nid, n in by_id.items() if n.get("label") == type_label}
return {
by_id[edge["target"]]["label"].strip(".()")
for edge in result["edges"]
if edge.get("relation") == "method" and edge.get("source") in type_ids
}
def test_interface_method_requirements_are_extracted(tmp_path: Path) -> None:
"""Each method requirement becomes a method node under the interface."""
(tmp_path / "go.mod").write_text("module example.com/repro\n\ngo 1.22\n")
(tmp_path / "shape.go").write_text(
"package repro\n\n"
"type Shape interface {\n"
"\tArea() float64\n"
"\tPerimeter() (float64, error)\n"
"}\n"
)
result = _extract(tmp_path)
assert _methods_of(result, "Shape") == {"Area", "Perimeter"}
def test_interface_embedding_still_produces_a_heritage_edge(tmp_path: Path) -> None:
"""A bare embedded interface stays an ``embeds`` edge, not a method."""
(tmp_path / "go.mod").write_text("module example.com/repro\n\ngo 1.22\n")
(tmp_path / "rw.go").write_text(
"package repro\n\n"
"type Reader interface {\n"
"\tRead(p []byte) (int, error)\n"
"}\n\n"
"type ReadCloser interface {\n"
"\tReader\n"
"\tClose() error\n"
"}\n"
)
result = _extract(tmp_path)
by_id = {node["id"]: node for node in result["nodes"]}
rc_ids = {nid for nid, n in by_id.items() if n.get("label") == "ReadCloser"}
reader_ids = {nid for nid, n in by_id.items() if n.get("label") == "Reader"}
# The embedded interface is heritage, not a method of ReadCloser.
assert any(
edge.get("relation") == "embeds"
and edge.get("source") in rc_ids
and edge.get("target") in reader_ids
for edge in result["edges"]
)
# Only the directly declared method requirement is a method of ReadCloser.
assert _methods_of(result, "ReadCloser") == {"Close"}
assert _methods_of(result, "Reader") == {"Read"}
def test_interface_method_is_distinct_from_a_concrete_method(tmp_path: Path) -> None:
"""An interface's ``Area`` and a struct's ``Area`` are two separate nodes."""
(tmp_path / "go.mod").write_text("module example.com/repro\n\ngo 1.22\n")
(tmp_path / "shape.go").write_text(
"package repro\n\n"
"type Shape interface {\n"
"\tArea() float64\n"
"}\n\n"
"type Rect struct{ W, H float64 }\n\n"
"func (r Rect) Area() float64 { return r.W * r.H }\n"
)
result = _extract(tmp_path)
by_id = {node["id"]: node for node in result["nodes"]}
shape_ids = {nid for nid, n in by_id.items() if n.get("label") == "Shape"}
rect_ids = {nid for nid, n in by_id.items() if n.get("label") == "Rect"}
shape_area = {
edge["target"]
for edge in result["edges"]
if edge.get("relation") == "method" and edge.get("source") in shape_ids
}
rect_area = {
edge["target"]
for edge in result["edges"]
if edge.get("relation") == "method" and edge.get("source") in rect_ids
}
assert shape_area and rect_area
assert shape_area.isdisjoint(rect_area), "interface and struct methods collapsed"
def _signature_refs(result: dict, owner_label: str) -> tuple[str, list[dict]]:
by_id = {node["id"]: node for node in result["nodes"]}
method_ids = {
edge["target"]
for edge in result["edges"]
if edge.get("relation") == "method"
and by_id[edge["source"]].get("label") == owner_label
}
assert len(method_ids) == 1
method_id = method_ids.pop()
return method_id, [
{**edge, "target_label": by_id[edge["target"]]["label"]}
for edge in result["edges"]
if edge.get("relation") == "references" and edge["source"] == method_id
]
@pytest.mark.parametrize(
("signature", "body"),
[
("Handle(Request) Response", "return Response{}"),
("Handle(req *Request) (res *Response, err error)", "return nil, nil"),
],
)
def test_interface_method_signature_keeps_type_references(tmp_path: Path, signature, body):
path = tmp_path / "contract.go"
path.write_text(
"package contracts\n\n"
"type Request struct{}\n"
"type Response struct{}\n"
"type Service interface {\n"
f" {signature}\n"
"}\n\n"
"type Impl struct{}\n"
f"func (Impl) {signature} {{ {body} }}\n",
encoding="utf-8",
)
result = _extract(tmp_path)
interface_id, interface_refs = _signature_refs(result, "Service")
concrete_id, concrete_refs = _signature_refs(result, "Impl")
expected = {("Request", "parameter_type"), ("Response", "return_type")}
assert {(edge["target_label"], edge["context"]) for edge in concrete_refs} == expected
assert {(edge["target_label"], edge["context"]) for edge in interface_refs} == expected
assert len(interface_refs) == 2
assert interface_id != concrete_id
assert not any(node["label"] == "error" for node in result["nodes"])
for edge in interface_refs:
assert edge["source_file"] == "contract.go"
assert edge["source_location"] == "L6"
assert edge["confidence"] == "EXTRACTED"
# A warm extraction replays the same source-owned signature edges.
warm = _extract(tmp_path)
assert _signature_refs(warm, "Service") == (interface_id, interface_refs)
assert _signature_refs(warm, "Impl") == (concrete_id, concrete_refs)
@pytest.mark.parametrize("names", [("Run", "run"), ("run", "Run"), ("Run", "RUN"), ("RUN", "Run")])
def test_case_only_interface_methods_keep_separate_signature_owners(tmp_path: Path, names):
path = tmp_path / "contract.go"
path.write_text(
"package contracts\n\n"
"type InputA struct{}\n"
"type InputB struct{}\n"
"type Service interface {\n"
f" {names[0]}(InputA)\n"
f" {names[1]}(InputB)\n"
"}\n"
"type Other interface { Run(InputA) }\n",
encoding="utf-8",
)
def owned_refs(result):
by_id = {node["id"]: node for node in result["nodes"]}
methods = {
by_id[edge["target"]]["label"]: edge["target"]
for edge in result["edges"]
if edge.get("relation") == "method"
and by_id[edge["source"]].get("label") == "Service"
}
assert set(methods) == {f".{name}()" for name in names}
assert len(set(methods.values())) == 2
for name, expected in zip(names, ("InputA", "InputB")):
refs = [
edge for edge in result["edges"]
if edge.get("relation") == "references"
and edge["source"] == methods[f".{name}()"]
]
assert len(refs) == 1
assert by_id[refs[0]["target"]]["label"] == expected
assert refs[0]["context"] == "parameter_type"
other_id, other_refs = _signature_refs(result, "Other")
assert other_id not in methods.values()
assert [edge["target_label"] for edge in other_refs] == ["InputA"]
return methods, other_id
result = _extract(tmp_path)
methods, other_id = owned_refs(result)
assert owned_refs(_extract(tmp_path)) == (methods, other_id)
# Declaration order cannot choose the canonical owner of a collision.
path.write_text(path.read_text().replace(
f" {names[0]}(InputA)\n {names[1]}(InputB)\n",
f" {names[1]}(InputB)\n {names[0]}(InputA)\n",
))
assert owned_refs(_extract(tmp_path)) == (methods, other_id)
# Removing the private sibling preserves the exported ID and other owners.
if "run" in names:
source = path.read_text()
path.write_text("\n".join(line for line in source.splitlines() if " run(" not in line))
without_private = _extract(tmp_path)
exported_id, _ = _signature_refs(without_private, "Service")
assert exported_id == methods[".Run()"]
assert _signature_refs(without_private, "Other")[0] == other_id